Skip to content

Remove Result type #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

Remove Result type #4

merged 1 commit into from
Jul 29, 2022

Conversation

dgraham
Copy link
Member

@dgraham dgraham commented Jul 29, 2022

Allow fetch to throw network errors and fail on non-200 responses.

@dgraham dgraham requested a review from iheanyi July 29, 2022 20:33
iheanyi
iheanyi approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@dgraham dgraham merged commit 09d80e7 into main Jul 29, 2022
@dgraham dgraham deleted the no-result branch July 29, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@iheanyi iheanyi iheanyi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgraham @iheanyi